linux-kernel - Re: [PATCH v2] btrfs: Remove error messages for failed memory allocations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <59c4741e-5749-4782-33f8-cc3a30ecf5e5@web.de>
Date:   Thu, 11 Jun 2020 16:00:21 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Liao Pingfang <liao.pingfang@....com.cn>,
        linux-btrfs@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Chris Mason <clm@...com>, David Sterba <dsterba@...e.com>,
        Josef Bacik <josef@...icpanda.com>,
        Wang Liang <wang.liang82@....com.cn>,
        Xue Zhihong <xue.zhihong@....com.cn>,
        Yi Wang <wang.yi59@....com.cn>
Subject: Re: [PATCH v2] btrfs: Remove error messages for failed memory
 allocations

> As there is a dump_stack() done on memory allocation
> failures, these messages might as well be deleted instead.

* I imagine that an other wording variant can become clearer
  for the change description.

* I suggest to reconsider the patch subject.


…
> +++ b/fs/btrfs/check-integrity.c
> @@ -632,7 +632,6 @@  static int btrfsic_process_superblock(struct btrfsic_state *state,
>
>  	selected_super = kzalloc(sizeof(*selected_super), GFP_NOFS);
>  	if (NULL == selected_super) {
> -		pr_info("btrfsic: error, kmalloc failed!\n");
>  		return -ENOMEM;
>  	}


How do you think about to use the following error handling instead?

	if (!selected_super)
		return -ENOMEM;


Regards,
Markus