linux-kernel - Re: [PATCH next] perf tools: fix potential memleak in perf events parser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <af4efc64-b55a-959c-b342-b70357f10173@huawei.com>
Date:   Thu, 11 Jun 2020 23:05:07 +0800
From:   Chen Wandun <chenwandun@...wei.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>, <Markus.Elfring@....de>
CC:     <linux-kernel@...r.kernel.org>, <peterz@...radead.org>,
        <mingo@...hat.com>, <cj.chengjian@...wei.com>,
        <chenwandun@...wei.com>
Subject: Re: [PATCH next] perf tools: fix potential memleak in perf events
 parser

在 2020/6/11 21:16, Arnaldo Carvalho de Melo 写道:
> Em Thu, Jun 11, 2020 at 09:42:34AM +0800, Chen Wandun escreveu:
>> Fix potential memory leak in function parse_events_term__sym_hw()
>> and parse_events_term__clone().
>>
>> 1. Free memory when errors occur.
>> 2. Function new_term may return error, so it is need to free memory
>>     when the return value is negative.
> Try to fix one thing per patch, i.e. first the most obvious one, then
> the other that requires going thru the new_term() logic, i.e. first
> this, which is super easy to review:

> Would you like to add the tag “Fixes” to the commit message?
>
Hi, Arnaldo and Markus.


Thank you for your reply, I will update in v2

Best Regards,

     Chen Wandun