linux-kernel - RE: [PATCH v1 2/2] scsi: ufs: Cleanup device vendor and quirk definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <001d01d64005$d7564e20$8602ea60$@samsung.com>
Date:   Thu, 11 Jun 2020 21:04:42 +0530
From:   "Alim Akhtar" <alim.akhtar@...sung.com>
To:     "'Stanley Chu'" <stanley.chu@...iatek.com>,
        <linux-scsi@...r.kernel.org>, <martin.petersen@...cle.com>,
        <avri.altman@....com>, <jejb@...ux.ibm.com>,
        <asutoshd@...eaurora.org>
Cc:     <beanhuo@...ron.com>, <cang@...eaurora.org>,
        <matthias.bgg@...il.com>, <bvanassche@....org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <kuohong.wang@...iatek.com>,
        <peter.wang@...iatek.com>, <chun-hung.wu@...iatek.com>,
        <andy.teng@...iatek.com>, <chaotian.jing@...iatek.com>,
        <cc.chou@...iatek.com>
Subject: RE: [PATCH v1 2/2] scsi: ufs: Cleanup device vendor and quirk
 definition

Hi Stanley

> -----Original Message-----
> From: Stanley Chu <stanley.chu@...iatek.com>
> Sent: 10 June 2020 11:07
> To: linux-scsi@...r.kernel.org; martin.petersen@...cle.com;
> avri.altman@....com; alim.akhtar@...sung.com; jejb@...ux.ibm.com;
> asutoshd@...eaurora.org
> Cc: beanhuo@...ron.com; cang@...eaurora.org; matthias.bgg@...il.com;
> bvanassche@....org; linux-mediatek@...ts.infradead.org; linux-arm-
> kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> kuohong.wang@...iatek.com; peter.wang@...iatek.com; chun-
> hung.wu@...iatek.com; andy.teng@...iatek.com;
> chaotian.jing@...iatek.com; cc.chou@...iatek.com; Stanley Chu
> <stanley.chu@...iatek.com>
> Subject: [PATCH v1 2/2] scsi: ufs: Cleanup device vendor and quirk
definition
> 
> Cleanup below items,
> - Arrange vendor name in alphabetical order
> - Squash device quirks as compact as possible in device quirk table
>   to enhance performance of the lookup.
> 
> Signed-off-by: Stanley Chu <stanley.chu@...iatek.com>
> ---
>  drivers/scsi/ufs/ufs_quirks.h | 2 +-
>  drivers/scsi/ufs/ufshcd.c     | 6 ++----
>  2 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufs_quirks.h b/drivers/scsi/ufs/ufs_quirks.h
index
> e80d5f26a442..2a0041493e30 100644
> --- a/drivers/scsi/ufs/ufs_quirks.h
> +++ b/drivers/scsi/ufs/ufs_quirks.h
> @@ -13,9 +13,9 @@
>  #define UFS_ANY_MODEL  "ANY_MODEL"
> 
>  #define UFS_VENDOR_MICRON      0x12C
> -#define UFS_VENDOR_TOSHIBA     0x198
>  #define UFS_VENDOR_SAMSUNG     0x1CE
>  #define UFS_VENDOR_SKHYNIX     0x1AD
> +#define UFS_VENDOR_TOSHIBA     0x198
>  #define UFS_VENDOR_WDC         0x145
> 
>  /**
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index
> dea4fddf9332..7c93cb446f51 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -219,10 +219,8 @@ static struct ufs_dev_fix ufs_fixups[] = {
>  	UFS_FIX(UFS_VENDOR_MICRON, UFS_ANY_MODEL,
>  		UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM),
>  	UFS_FIX(UFS_VENDOR_SAMSUNG, UFS_ANY_MODEL,
> -		UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM),
> -	UFS_FIX(UFS_VENDOR_SAMSUNG, UFS_ANY_MODEL,
> -		UFS_DEVICE_QUIRK_RECOVERY_FROM_DL_NAC_ERRORS),
> -	UFS_FIX(UFS_VENDOR_SAMSUNG, UFS_ANY_MODEL,
> +		UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM |
> +		UFS_DEVICE_QUIRK_RECOVERY_FROM_DL_NAC_ERRORS |
>  		UFS_DEVICE_QUIRK_HOST_PA_TACTIVATE),
>  	UFS_FIX(UFS_VENDOR_TOSHIBA, UFS_ANY_MODEL,
>  		UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM),
> --
While at this, may be arrange the table in alphabetical order.

> 2.18.0