linux-kernel - Re: [PATCH] drm/bridge: make array frs_limits static, makes object smaller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <17564b0632ef8ca6a64023fe430d69e861f252f1.camel@perches.com>
Date:   Thu, 11 Jun 2020 11:01:41 -0700
From:   Joe Perches <joe@...ches.com>
To:     Colin King <colin.king@...onical.com>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: make array frs_limits static, makes object
 smaller

On Thu, 2020-06-11 at 14:39 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Don't populate the array frs_limits on the stack but instead make it
> static. Makes the object code smaller by 123 bytes
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>   23456	   5712	     64	  29232	   7230	drivers/gpu/drm/bridge/tc358768.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>   23333	   5712	     64	  29109	   71b5	drivers/gpu/drm/bridge/tc358768.o
> 
> (gcc version 9.3.0, amd64)

It's curious that the data size didn't change.

Perhaps you should make sure you do not compile
with allyesconfig when you show these change.

For instance: x86-64 defconfig with this bridge
enabled:

$ size drivers/gpu/drm/bridge/tc358768.o
   text	   data	    bss	    dec	    hex	filename
   9423	    300	      0	   9723	   25fb	drivers/gpu/drm/bridge/tc358768.o