linux-kernel - Re: [PATCH] lib/vdso: use CLOCK_REALTIME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878sgt1jo2.fsf@nanos.tec.linutronix.de>
Date:   Thu, 11 Jun 2020 21:34:05 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Mark Salyzyn <salyzyn@...roid.com>, linux-kernel@...r.kernel.org
Cc:     kernel-team@...roid.com, Chiawei Wang <chiaweiwang@...gle.com>,
        Mark Salyzyn <salyzyn@...roid.com>, stable@...r.kernel.org,
        Andy Lutomirski <luto@...nel.org>,
        Vincenzo Frascino <vincenzo.frascino@....com>
Subject: Re: [PATCH] lib/vdso: use CLOCK_REALTIME_COARSE for time()

Mark Salyzyn <salyzyn@...roid.com> writes:
> From: Chiawei Wang <chiaweiwang@...gle.com>
>
> CLOCK_REALTIME in vdso data won't be updated if
> __arch_use_vsyscall() returns false.

Errm!

# git grep __arch_use_vsyscall
#

Aside of that update_vsyscall() updates CLOCK_REALTIME data
unconditionally. No idea what this patch is solving.

> Cc: stable@...r.kernel.org # 5.4+

This # 5.4+ is pointless. You really want to add a fixes tag which pin
points the commit which introduced the wreckage.

But thats moot as this is not fixing anything not even in 5.4.

I assume this was developed against some Frankenkernel which has a messy
backport or a snapshot of some development version of that vdso stuff.

Not that I want to know, but please make sure that something you send my
way makes sense on sane kernels.

Oh well.

Thanks,

        tglx