| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <70e6cefd-20f7-7e5f-918f-3bcb721b9a66@samsung.com>
Date: Fri, 12 Jun 2020 14:20:08 +0200
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To: kernel test robot <lkp@...el.com>
Cc: kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
Jens Axboe <axboe@...nel.dk>, Christoph Hellwig <hch@....de>
Subject: Re: include/linux/libata.h:1366:2: note: in expansion of macro
'__ATA_BASE_SHT'
On 6/12/20 9:58 AM, kernel test robot wrote:
> Hi Bartlomiej,
Hi,
> FYI, the error/warning still remains.
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: b791d1bdf9212d944d749a5c7ff6febdba241771
> commit: 6f09eae3b5d974ef845e56690d6bc2b8f2a70acd ata: expose ncq_enable_prio sysfs attribute only on NCQ capable hosts
> date: 3 months ago
> config: i386-randconfig-r011-20200612 (attached as .config)
> compiler: gcc-4.9 (Ubuntu 4.9.3-13ubuntu2) 4.9.3
> reproduce (this is a W=1 build):
> git checkout 6f09eae3b5d974ef845e56690d6bc2b8f2a70acd
> # save the attached .config to linux build tree
> make W=1 ARCH=i386
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
>
> All warnings (new ones prefixed by >>, old ones prefixed by <<):
>
> In file included from include/linux/linkage.h:7:0,
> from include/linux/kernel.h:8,
> from drivers/ata/ahci_platform.c:11:
> include/linux/export.h:19:30: warning: initialized field overwritten [-Woverride-init]
> #define THIS_MODULE ((struct module *)0)
> ^
> include/linux/libata.h:1346:14: note: in expansion of macro 'THIS_MODULE'
> .module = THIS_MODULE, ^
>>> include/linux/libata.h:1366:2: note: in expansion of macro '__ATA_BASE_SHT'
> __ATA_BASE_SHT(drv_name), ^
> drivers/ata/ahci.h:383:2: note: in expansion of macro 'ATA_NCQ_SHT'
> ATA_NCQ_SHT(drv_name), ^
> drivers/ata/ahci_platform.c:40:2: note: in expansion of macro 'AHCI_SHT'
> AHCI_SHT(DRV_NAME),
> ^
> include/linux/export.h:19:30: warning: (near initialization for 'ahci_platform_sht.can_queue') [-Woverride-init]
> #define THIS_MODULE ((struct module *)0)
> ^
> include/linux/libata.h:1346:14: note: in expansion of macro 'THIS_MODULE'
> .module = THIS_MODULE, ^
>>> include/linux/libata.h:1366:2: note: in expansion of macro '__ATA_BASE_SHT'
> __ATA_BASE_SHT(drv_name), ^
> drivers/ata/ahci.h:383:2: note: in expansion of macro 'ATA_NCQ_SHT'
> ATA_NCQ_SHT(drv_name), ^
> drivers/ata/ahci_platform.c:40:2: note: in expansion of macro 'AHCI_SHT'
> AHCI_SHT(DRV_NAME),
> ^
> include/linux/export.h:19:30: warning: initialized field overwritten [-Woverride-init]
> #define THIS_MODULE ((struct module *)0)
> ^
> include/linux/libata.h:1346:14: note: in expansion of macro 'THIS_MODULE'
> .module = THIS_MODULE, ^
>>> include/linux/libata.h:1366:2: note: in expansion of macro '__ATA_BASE_SHT'
> __ATA_BASE_SHT(drv_name), ^
> drivers/ata/ahci.h:383:2: note: in expansion of macro 'ATA_NCQ_SHT'
> ATA_NCQ_SHT(drv_name), ^
> drivers/ata/ahci_platform.c:40:2: note: in expansion of macro 'AHCI_SHT'
> AHCI_SHT(DRV_NAME),
> ^
> include/linux/export.h:19:30: warning: (near initialization for 'ahci_platform_sht.sdev_attrs') [-Woverride-init]
> #define THIS_MODULE ((struct module *)0)
> ^
> include/linux/libata.h:1346:14: note: in expansion of macro 'THIS_MODULE'
> .module = THIS_MODULE, ^
>>> include/linux/libata.h:1366:2: note: in expansion of macro '__ATA_BASE_SHT'
> __ATA_BASE_SHT(drv_name), ^
> drivers/ata/ahci.h:383:2: note: in expansion of macro 'ATA_NCQ_SHT'
> ATA_NCQ_SHT(drv_name), ^
> drivers/ata/ahci_platform.c:40:2: note: in expansion of macro 'AHCI_SHT'
> AHCI_SHT(DRV_NAME),
> ^
> --
> In file included from include/linux/linkage.h:7:0,
> from include/linux/kernel.h:8,
> from drivers/ata/ahci_ceva.c:10:
> include/linux/export.h:19:30: warning: initialized field overwritten [-Woverride-init]
> #define THIS_MODULE ((struct module *)0)
> ^
> include/linux/libata.h:1346:14: note: in expansion of macro 'THIS_MODULE'
> .module = THIS_MODULE, ^
>>> include/linux/libata.h:1366:2: note: in expansion of macro '__ATA_BASE_SHT'
> __ATA_BASE_SHT(drv_name), ^
> drivers/ata/ahci.h:383:2: note: in expansion of macro 'ATA_NCQ_SHT'
> ATA_NCQ_SHT(drv_name), ^
> drivers/ata/ahci_ceva.c:187:2: note: in expansion of macro 'AHCI_SHT'
> AHCI_SHT(DRV_NAME),
> ^
> include/linux/export.h:19:30: warning: (near initialization for 'ahci_platform_sht.can_queue') [-Woverride-init]
> #define THIS_MODULE ((struct module *)0)
> ^
> include/linux/libata.h:1346:14: note: in expansion of macro 'THIS_MODULE'
> .module = THIS_MODULE, ^
>>> include/linux/libata.h:1366:2: note: in expansion of macro '__ATA_BASE_SHT'
> __ATA_BASE_SHT(drv_name), ^
> drivers/ata/ahci.h:383:2: note: in expansion of macro 'ATA_NCQ_SHT'
> ATA_NCQ_SHT(drv_name), ^
> drivers/ata/ahci_ceva.c:187:2: note: in expansion of macro 'AHCI_SHT'
> AHCI_SHT(DRV_NAME),
> ^
> include/linux/export.h:19:30: warning: initialized field overwritten [-Woverride-init]
> #define THIS_MODULE ((struct module *)0)
> ^
> include/linux/libata.h:1346:14: note: in expansion of macro 'THIS_MODULE'
> .module = THIS_MODULE, ^
>>> include/linux/libata.h:1366:2: note: in expansion of macro '__ATA_BASE_SHT'
> __ATA_BASE_SHT(drv_name), ^
> drivers/ata/ahci.h:383:2: note: in expansion of macro 'ATA_NCQ_SHT'
> ATA_NCQ_SHT(drv_name), ^
> drivers/ata/ahci_ceva.c:187:2: note: in expansion of macro 'AHCI_SHT'
> AHCI_SHT(DRV_NAME),
> ^
> include/linux/export.h:19:30: warning: (near initialization for 'ahci_platform_sht.sdev_attrs') [-Woverride-init]
> #define THIS_MODULE ((struct module *)0)
> ^
> include/linux/libata.h:1346:14: note: in expansion of macro 'THIS_MODULE'
> .module = THIS_MODULE, ^
>>> include/linux/libata.h:1366:2: note: in expansion of macro '__ATA_BASE_SHT'
> __ATA_BASE_SHT(drv_name), ^
> drivers/ata/ahci.h:383:2: note: in expansion of macro 'ATA_NCQ_SHT'
> ATA_NCQ_SHT(drv_name), ^
> drivers/ata/ahci_ceva.c:187:2: note: in expansion of macro 'AHCI_SHT'
> AHCI_SHT(DRV_NAME),
> ^
>
> vim +/__ATA_BASE_SHT +1366 include/linux/libata.h
>
> 1338
> 1339 /*
> 1340 * All sht initializers (BASE, PIO, BMDMA, NCQ) must be instantiated
> 1341 * by the edge drivers. Because the 'module' field of sht must be the
> 1342 * edge driver's module reference, otherwise the driver can be unloaded
> 1343 * even if the scsi_device is being accessed.
> 1344 */
> 1345 #define __ATA_BASE_SHT(drv_name) \
>> 1346 .module = THIS_MODULE, \
> 1347 .name = drv_name, \
> 1348 .ioctl = ata_scsi_ioctl, \
> 1349 ATA_SCSI_COMPAT_IOCTL \
> 1350 .queuecommand = ata_scsi_queuecmd, \
> 1351 .can_queue = ATA_DEF_QUEUE, \
> 1352 .tag_alloc_policy = BLK_TAG_ALLOC_RR, \
> 1353 .this_id = ATA_SHT_THIS_ID, \
> 1354 .emulated = ATA_SHT_EMULATED, \
> 1355 .proc_name = drv_name, \
> 1356 .slave_configure = ata_scsi_slave_config, \
> 1357 .slave_destroy = ata_scsi_slave_destroy, \
> 1358 .bios_param = ata_std_bios_param, \
> 1359 .unlock_native_capacity = ata_scsi_unlock_native_capacity
> 1360
> 1361 #define ATA_BASE_SHT(drv_name) \
> 1362 __ATA_BASE_SHT(drv_name), \
> 1363 .sdev_attrs = ata_common_sdev_attrs
> 1364
> 1365 #define ATA_NCQ_SHT(drv_name) \
>> 1366 __ATA_BASE_SHT(drv_name), \
> 1367 .sdev_attrs = ata_ncq_sdev_attrs, \
> 1368 .change_queue_depth = ata_scsi_change_queue_depth
> 1369
>
The above warnings produced by gcc-4.9 are very misleading, gcc-5.4
(Ubuntu 5.4.0-6ubuntu1~16.04.11) produces much more descriptive ones:
CC drivers/ata/ahci_platform.o
In file included from drivers/ata/ahci_platform.c:21:0:
drivers/ata/ahci.h:384:16: warning: initialized field overwritten [-Woverride-init]
.can_queue = AHCI_MAX_CMDS, \
^
drivers/ata/ahci_platform.c:40:2: note: in expansion of macro ‘AHCI_SHT’
AHCI_SHT(DRV_NAME),
^
drivers/ata/ahci.h:384:16: note: (near initialization for ‘ahci_platform_sht.can_queue’)
.can_queue = AHCI_MAX_CMDS, \
^
drivers/ata/ahci_platform.c:40:2: note: in expansion of macro ‘AHCI_SHT’
AHCI_SHT(DRV_NAME),
^
drivers/ata/ahci.h:388:17: warning: initialized field overwritten [-Woverride-init]
.sdev_attrs = ahci_sdev_attrs
^
drivers/ata/ahci_platform.c:40:2: note: in expansion of macro ‘AHCI_SHT’
AHCI_SHT(DRV_NAME),
^
drivers/ata/ahci.h:388:17: note: (near initialization for ‘ahci_platform_sht.sdev_attrs’)
.sdev_attrs = ahci_sdev_attrs
^
drivers/ata/ahci_platform.c:40:2: note: in expansion of macro ‘AHCI_SHT’
AHCI_SHT(DRV_NAME),
^
CC drivers/ata/libahci.o
CC drivers/ata/libahci_platform.o
CC drivers/ata/sata_dwc_460ex.o
CC drivers/ata/ahci_ceva.o
In file included from drivers/ata/ahci_ceva.c:15:0:
drivers/ata/ahci.h:384:16: warning: initialized field overwritten [-Woverride-init]
.can_queue = AHCI_MAX_CMDS, \
^
drivers/ata/ahci_ceva.c:187:2: note: in expansion of macro ‘AHCI_SHT’
AHCI_SHT(DRV_NAME),
^
drivers/ata/ahci.h:384:16: note: (near initialization for ‘ahci_platform_sht.can_queue’)
.can_queue = AHCI_MAX_CMDS, \
^
drivers/ata/ahci_ceva.c:187:2: note: in expansion of macro ‘AHCI_SHT’
AHCI_SHT(DRV_NAME),
^
drivers/ata/ahci.h:388:17: warning: initialized field overwritten [-Woverride-init]
.sdev_attrs = ahci_sdev_attrs
^
drivers/ata/ahci_ceva.c:187:2: note: in expansion of macro ‘AHCI_SHT’
AHCI_SHT(DRV_NAME),
^
drivers/ata/ahci.h:388:17: note: (near initialization for ‘ahci_platform_sht.sdev_attrs’)
.sdev_attrs = ahci_sdev_attrs
^
drivers/ata/ahci_ceva.c:187:2: note: in expansion of macro ‘AHCI_SHT’
AHCI_SHT(DRV_NAME),
^
Also it turns out that this is an old issue and not a regression
introduced by commit 6f09eae3b5d974ef845e56690d6bc2b8f2a70acd
("ata: expose ncq_enable_prio sysfs attribute only on NCQ capable
hosts").
Anyway, it should be fixed by:
https://lore.kernel.org/linux-ide/0d803e72-b15e-4673-4858-4741f2772fc4@samsung.com/
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Powered by blists - more mailing lists