linux-kernel - Re: [PATCH RT 3/4] tasklet: Fix UP case for tasklet CHAINED state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200612130952.wzyzebdc2wxahxkh@linutronix.de>
Date:   Fri, 12 Jun 2020 15:09:52 +0200
From:   Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:     zanussi@...nel.org
Cc:     LKML <linux-kernel@...r.kernel.org>,
        linux-rt-users <linux-rt-users@...r.kernel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Carsten Emde <C.Emde@...dl.org>,
        John Kacur <jkacur@...hat.com>, Daniel Wagner <wagi@...om.org>,
        Clark Williams <williams@...hat.com>,
        Pavel Machek <pavel@...x.de>
Subject: Re: [PATCH RT 3/4] tasklet: Fix UP case for tasklet CHAINED state

On 2020-06-11 13:10:16 [-0500], zanussi@...nel.org wrote:
> commit 62d0a2a30cd0 (tasklet: Address a race resulting in
> double-enqueue) addresses a problem that can result in a tasklet being
> enqueued on two cpus at the same time by combining the RUN flag with a
> new CHAINED flag, and relies on the combination to be present in order
> to zero it out, which can never happen on (!SMP and !PREEMPT_RT_FULL)
> because the RUN flag is SMP/PREEMPT_RT_FULL-only.
> 
> So make sure the above commit is only applied for the SMP ||
> PREEMPT_RT_FULL case.
> 
> Fixes: 62d0a2a30cd0 ("tasklet: Address a race resulting in double-enqueue")
> Signed-off-by: Tom Zanussi <zanussi@...nel.org>
> Reported-by: Ramon Fried <rfried.dev@...il.com>
> Tested-By: Ramon Fried <rfried.dev@...il.com>

Acked-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

Sebastian