linux-kernel - Re: [PATCH v1] Bluetooth: hci_qca: Request Tx clock vote off only when Tx is pending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <29DD7F7E-A91D-439D-9FAA-23C8A16BD586@holtmann.org>
Date:   Fri, 12 Jun 2020 15:19:30 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Balakrishna Godavarthi <bgodavar@...eaurora.org>
Cc:     Johan Hedberg <johan.hedberg@...il.com>, mka@...omium.org,
        linux-kernel@...r.kernel.org, linux-bluetooth@...r.kernel.org,
        hemantg@...eaurora.org, linux-arm-msm@...r.kernel.org,
        abhishekpandit@...omium.org, rjliao@...eaurora.org,
        gubbaven@...eaurora.org
Subject: Re: [PATCH v1] Bluetooth: hci_qca: Request Tx clock vote off only
 when Tx is pending

Hi Balakrishna,

> Tx pending flag is set to true when HOST IBS state is AWAKE or
> AWAKEING. If IBS state is ASLEEP, then Tx clock is already voted
> off. To optimize further directly calling serial_clock_vote()
> instead of qca_wq_serial_tx_clock_vote_off(), at this point of
> qca_suspend() already data is sent out. No need to wake up hci to
> send data.
> 
> Signed-off-by: Balakrishna Godavarthi <bgodavar@...eaurora.org>
> ---
> drivers/bluetooth/hci_qca.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel