linux-kernel - Re: [PATCH] memory: tegra: Avoid double error messaging when IRQ absent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2707086c-e604-d0d6-66fa-072e5844e923@gmail.com>
Date:   Fri, 12 Jun 2020 17:15:39 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Keyur Patel <iamkeyur96@...il.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Peter De Schrijver <pdeschrijver@...dia.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] memory: tegra: Avoid double error messaging when IRQ
 absent

11.06.2020 22:07, Keyur Patel пишет:
> Since the commit 7723f4c ("driver core: platform: Add an error message
> to platform_get_irq*()") platform_get_irq() started issuing an error message.
> Thus, there is no need to have the same in the driver.
> 
> Signed-off-by: Keyur Patel <iamkeyur96@...il.com>
> ---
>  drivers/memory/tegra/mc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c
> index ec8403557ed4..f519c0987485 100644
> --- a/drivers/memory/tegra/mc.c
> +++ b/drivers/memory/tegra/mc.c
> @@ -659,10 +659,8 @@ static int tegra_mc_probe(struct platform_device *pdev)
>  	}
>  
>  	mc->irq = platform_get_irq(pdev, 0);
> -	if (mc->irq < 0) {
> -		dev_err(&pdev->dev, "interrupt not specified\n");
> +	if (mc->irq < 0)
>  		return mc->irq;
> -	}
>  
>  	WARN(!mc->soc->client_id_mask, "missing client ID mask for this SoC\n");
>  
> 

Reviewed-by: Dmitry Osipenko <digetx@...il.com>