lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 12 Jun 2020 12:35:24 -0700
From:   Matthew Wilcox <>
To:     Ralph Campbell <>
        Jerome Glisse <>,
        John Hubbard <>,
        Christoph Hellwig <>,
        Jason Gunthorpe <>,
        Andrew Morton <>
Subject: Re: [PATCH] mm/hmm: remove redundant check non_swap_entry()

On Fri, Jun 12, 2020 at 12:26:18PM -0700, Ralph Campbell wrote:
> In zap_pte_range(), the check for non_swap_entry() and
> is_device_private_entry() is redundant since the latter is a subset of the
> former. Remove the redundant check to simplify the code and for clarity.

That is highly configuration dependent.

static inline bool is_device_private_entry(swp_entry_t entry)
        return false;

#if defined(CONFIG_MEMORY_FAILURE) || defined(CONFIG_MIGRATION) || \
static inline int non_swap_entry(swp_entry_t entry)
        return swp_type(entry) >= MAX_SWAPFILES;
static inline int non_swap_entry(swp_entry_t entry)
        return 0;

Powered by blists - more mailing lists