linux-kernel - Re: [PATCH v10 3/4] dt-bindings: media: i2c: Add bindings for IMI RDACM2x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200612221103.GA3902762@bogus>
Date:   Fri, 12 Jun 2020 16:11:03 -0600
From:   Rob Herring <robh@...nel.org>
To:     Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
Cc:     Hyun Kwon <hyunk@...inx.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Kieran Bingham <kieran.bingham@...asonboard.com>,
        sakari.ailus@....fi, linux-media@...r.kernel.org,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Hans Verkuil <hverkuil@...all.nl>,
        linux-renesas-soc@...r.kernel.org,
        Jacopo Mondi <jacopo+renesas@...ndi.org>,
        devicetree@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Niklas Söderlund 
        <niklas.soderlund@...natech.se>, Jacopo Mondi <jacopo@...ndi.org>
Subject: Re: [PATCH v10 3/4] dt-bindings: media: i2c: Add bindings for IMI
 RDACM2x

On Fri, 12 Jun 2020 15:47:12 +0100, Kieran Bingham wrote:
> From: Jacopo Mondi <jacopo+renesas@...ndi.org>
> 
> The IMI RDACM20 and IMI RDACM21 are Gigabit Multimedia Serial Link
> (GMSL) camera capable of transmitting video and I2C control messages on
> a coax cable physical link for automotive applications.
> 
> Document their device tree bindings.
> 
> Signed-off-by: Jacopo Mondi <jacopo+renesas@...ndi.org>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Reviewed-by: Rob Herring <robh@...nel.org>
> 
> ---
> v2:
>  - Provide imi vendor prefix
>  - Fix minor spelling
> 
> v3:
>  - update binding descriptions
> 
> v4:
>  - No change
> 
> v5:
>  - Specify optional third reg address for the MCU
> 
> v7:
>  [Jacopo]
>  - Rename to imi,rdacm2x-gmsl.yaml
>  - Exand bindings to describe RDACM21
> 
> v9:
>   [Jacopo]
>   - Rework 'compatible' property as suggested by Rob
>   - Re-order vendor prefixes ('g' comes before 'i' ... )
>   - Add Rob's tag
> 
>  .../bindings/media/i2c/imi,rdacm2x-gmsl.yaml  | 159 ++++++++++++++++++
>  .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
>  2 files changed, 161 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/imi,rdacm2x-gmsl.yaml
> 


My bot found errors running 'make dt_binding_check' on your patch:

/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/imi,rdacm2x-gmsl.example.dt.yaml: example-0: i2c@...d8000:reg:0: [0, 3865935872, 0, 64] is too long
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/imi,rdacm2x-gmsl.example.dt.yaml: example-1: i2c@...d8000:reg:0: [0, 3865935872, 0, 64] is too long


See https://patchwork.ozlabs.org/patch/1308279

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:

pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade

Please check and re-submit.