lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 12 Jun 2020 16:19:54 -0600 From: Rob Herring <robh@...nel.org> To: Luca Ceresoli <luca@...aceresoli.net> Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, Lee Jones <lee.jones@...aro.org>, Keerthy <j-keerthy@...com>, Axel Lin <axel.lin@...ics.com> Subject: Re: [RFC 2/4] regulator: lp87565: dt: remove duplicated section On Wed, Jun 03, 2020 at 10:03:17PM +0200, Luca Ceresoli wrote: > The "Required properties:" section is copied verbatim for each of the two > supported chips. In preparation to add a new chip variant make it a common > section and keep the two examples to differentiate between the two chips. > > Signed-off-by: Luca Ceresoli <luca@...aceresoli.net> > --- > .../devicetree/bindings/mfd/lp87565.txt | 21 ++++--------------- > 1 file changed, 4 insertions(+), 17 deletions(-) If you want to clean this up, can you convert it to DT schema? > > diff --git a/Documentation/devicetree/bindings/mfd/lp87565.txt b/Documentation/devicetree/bindings/mfd/lp87565.txt > index 41671e0dc26b..b75ae23a1ef3 100644 > --- a/Documentation/devicetree/bindings/mfd/lp87565.txt > +++ b/Documentation/devicetree/bindings/mfd/lp87565.txt > @@ -1,7 +1,7 @@ > TI LP87565 PMIC MFD driver > > Required properties: > - - compatible: "ti,lp87565", "ti,lp87565-q1" > + - compatible: one of "ti,lp87565", "ti,lp87565-q1", "ti,lp87561-q1" > - reg: I2C slave address. > - gpio-controller: Marks the device node as a GPIO Controller. > - #gpio-cells: Should be two. The first cell is the pin number and > @@ -10,7 +10,8 @@ Required properties: > - xxx-in-supply: Phandle to parent supply node of each regulator > populated under regulators node. xxx should match > the supply_name populated in driver. > -Example: > + > +Example for the TI LP87565-Q1 PMIC (dual 2-phase output configuration): > > lp87565_pmic: pmic@60 { > compatible = "ti,lp87565-q1"; > @@ -42,21 +43,7 @@ lp87565_pmic: pmic@60 { > }; > }; > > -TI LP87561 PMIC: > - > -This is a single output 4-phase regulator configuration > - > -Required properties: > - - compatible: "ti,lp87561-q1" > - - reg: I2C slave address. > - - gpio-controller: Marks the device node as a GPIO Controller. > - - #gpio-cells: Should be two. The first cell is the pin number and > - the second cell is used to specify flags. > - See ../gpio/gpio.txt for more information. > - - xxx-in-supply: Phandle to parent supply node of each regulator > - populated under regulators node. xxx should match > - the supply_name populated in driver. > -Example: > +Example for the TI LP87561 PMIC (single 4-phase output configuration): > > lp87561_pmic: pmic@62 { > compatible = "ti,lp87561-q1"; > -- > 2.27.0 >
Powered by blists - more mailing lists