linux-kernel - Re: [PATCH] vimc: Add colors' order over test image

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 13 Jun 2020 06:44:17 +0800
From:   kernel test robot <lkp@...el.com>
To:     Kaaira Gupta <kgupta@...iitr.ac.in>, hverkuil@...all.nl,
        Helen Koike <helen.koike@...labora.com>,
        Shuah Khan <skhan@...uxfoundation.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-kernel@...r.kernel.org,
        Kieran Bingham <kieran.bingham@...asonboard.com>
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        linux-media@...r.kernel.org
Subject: Re: [PATCH] vimc: Add colors' order over test image

Hi Kaaira,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on next-20200612]
[cannot apply to v5.7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Kaaira-Gupta/vimc-Add-colors-order-over-test-image/20200613-015755
base:   git://linuxtv.org/media_tree.git master
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 3b43f006294971b8049d4807110032169780e5b8)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/media/common/v4l2-tpg/v4l2-tpg-core.c:2012:52: warning: converting the enum constant to a boolean [-Wint-in-bool-context]
case (TPG_PAT_75_COLORBAR || TPG_PAT_100_COLORBAR || TPG_PAT_CSC_COLORBAR):
^
>> drivers/media/common/v4l2-tpg/v4l2-tpg-core.c:2027:3: error: non-void function 'tpg_g_color_order' should return a value [-Wreturn-type]
return;
^
1 warning and 1 error generated.

vim +/tpg_g_color_order +2027 drivers/media/common/v4l2-tpg/v4l2-tpg-core.c

  2008	
  2009	const char *tpg_g_color_order(const struct tpg_data *tpg)
  2010	{
  2011		switch (tpg->pattern) {
> 2012		case (TPG_PAT_75_COLORBAR || TPG_PAT_100_COLORBAR || TPG_PAT_CSC_COLORBAR):
  2013			return "Left to right: white, yellow, cyan, green, magenta, red, blue, black";
  2014		case TPG_PAT_100_HCOLORBAR:
  2015			return "Top to bottom: white, yellow, cyan, green, magenta, red, blue, black";
  2016		case TPG_PAT_BLACK:
  2017			return "Black";
  2018		case TPG_PAT_WHITE:
  2019			return "White";
  2020		case TPG_PAT_RED:
  2021			return "Red";
  2022		case TPG_PAT_GREEN:
  2023			return "Green";
  2024		case TPG_PAT_BLUE:
  2025			return "Blue";
  2026		default:
> 2027			return;
  2028		}
  2029	}
  2030	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (73691 bytes)