linux-kernel - [PATCH] iio: accel: Replace symbolic permissions with octal permissions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 13 Jun 2020 13:49:01 +0530
From:   Mugilraj D <dmugil2000@...il.com>
To:     unlisted-recipients:; (no To-header on input)
Cc:     Mugilraj D <dmugil2000@...il.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Linus Walleij <linus.walleij@...aro.org>,
        Jonathan Bakker <xc-racer2@...e.ca>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] iio: accel: Replace symbolic permissions with octal permissions

Resolve following checkpatch issue:
WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider
using octal permissions '0444'.

Signed-off-by: Mugilraj D <dmugil2000@...il.com>
---
 drivers/iio/accel/bma180.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
index 265722e..b716347 100644
--- a/drivers/iio/accel/bma180.c
+++ b/drivers/iio/accel/bma180.c
@@ -531,14 +531,13 @@ static ssize_t bma180_show_scale_avail(struct device *dev,
 }
 
 static IIO_DEVICE_ATTR(in_accel_filter_low_pass_3db_frequency_available,
-	S_IRUGO, bma180_show_filter_freq_avail, NULL, 0);
+	0444, bma180_show_filter_freq_avail, NULL, 0);
 
 static IIO_DEVICE_ATTR(in_accel_scale_available,
-	S_IRUGO, bma180_show_scale_avail, NULL, 0);
+	0444, bma180_show_scale_avail, NULL, 0);
 
 static struct attribute *bma180_attributes[] = {
-	&iio_dev_attr_in_accel_filter_low_pass_3db_frequency_available.
-		dev_attr.attr,
+	&iio_dev_attr_in_accel_filter_low_pass_3db_frequency_available.dev_attr.attr,
 	&iio_dev_attr_in_accel_scale_available.dev_attr.attr,
 	NULL,
 };
-- 
2.7.4