linux-kernel - Re: [PATCH] net: ethernet: ti: ale: fix allmulti for nu type ale

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200613.153801.1383724005122062451.davem@davemloft.net>
Date:   Sat, 13 Jun 2020 15:38:01 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     grygorii.strashko@...com
Cc:     netdev@...r.kernel.org, kuba@...nel.org, m-karicheri2@...com,
        nsekhar@...com, linux-kernel@...r.kernel.org,
        linux-omap@...r.kernel.org
Subject: Re: [PATCH] net: ethernet: ti: ale: fix allmulti for nu type ale

From: Grygorii Strashko <grygorii.strashko@...com>
Date: Sat, 13 Jun 2020 17:54:14 +0300

> On AM65xx MCU CPSW2G NUSS and 66AK2E/L NUSS allmulti setting does not allow
> unregistered mcast packets to pass.
> 
> This happens, because ALE VLAN entries on these SoCs do not contain port
> masks for reg/unreg mcast packets, but instead store indexes of
> ALE_VLAN_MASK_MUXx_REG registers which intended for store port masks for
> reg/unreg mcast packets.
> This path was missed by commit 9d1f6447274f ("net: ethernet: ti: ale: fix
> seeing unreg mcast packets with promisc and allmulti disabled").
> 
> Hence, fix it by taking into account ALE type in cpsw_ale_set_allmulti().
> 
> Fixes: 9d1f6447274f ("net: ethernet: ti: ale: fix seeing unreg mcast packets with promisc and allmulti disabled")
> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>

Applied and queued up for v5.7 -stable.