[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CABVgOSkMv22GDGin8GCqq4Vd=Bff7-VzEycmzKhUeKj9tErD7Q@mail.gmail.com>
Date: Sat, 13 Jun 2020 14:56:43 +0800
From: David Gow <davidgow@...gle.com>
To: Vitor Massaru Iha <vitor@...saru.org>
Cc: KUnit Development <kunit-dev@...glegroups.com>,
Shuah Khan <skhan@...uxfoundation.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Brendan Higgins <brendanhiggins@...gle.com>,
linux-kernel-mentees@...ts.linuxfoundation.org,
Kees Cook <keescook@...omium.org>, linux@...musvillemoes.dk
Subject: Re: [PATCH] lib: kunit_test_overflow: add KUnit test of
check_*_overflow functions
On Fri, Jun 12, 2020 at 5:55 AM Vitor Massaru Iha <vitor@...saru.org> wrote:
>
> This adds the convertion of the runtime tests of check_*_overflow fuctions,
> from `lib/test_overflow.c`to KUnit tests.
Nit: couple of minor typos here: convertion -> conversion, and
functions -> functions
> The log similar to the one seen in dmesg running test_overflow can be
> seen in `test.log`.
>
> Signed-off-by: Vitor Massaru Iha <vitor@...saru.org>
I've tested that this builds and runs on my system, and it all seems
to be working fine!
Tested-by: David Gow <davidgow@...gle.com>
> ---
> lib/Kconfig.debug | 17 ++
> lib/Makefile | 1 +
> lib/kunit_overflow_test.c | 590 ++++++++++++++++++++++++++++++++++++++
> 3 files changed, 608 insertions(+)
> create mode 100644 lib/kunit_overflow_test.c
Echoing what Brendan and Kees mentioned, it'd be nicer to have this
replace the existing test, both because there's no need for redundant
tests (one will get out-of-date), and so that we can have a nice diff
showing the changes made as part of the conversion.
Cheers,
-- David
Powered by blists - more mailing lists