linux-kernel - Re: [PATCH] RDMA/rvt: Improve exception handling in rvt_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d99dfe5-67ed-00d2-c2da-77058fb770c6@web.de>
Date:   Sat, 13 Jun 2020 09:15:12 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Aditya Pakki <pakki001@....edu>, linux-rdma@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Dennis Dalessandro <dennis.dalessandro@...el.com>,
        Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>, Kangjie Lu <kjlu@....edu>,
        Mike Marciniszyn <mike.marciniszyn@...el.com>,
        Qiushi Wu <wu000273@....edu>
Subject: Re: [PATCH] RDMA/rvt: Improve exception handling in rvt_create_qp()

> … The patch fixes this issue by
> calling rvt_free_rq().

I suggest to choose another imperative wording for your change description.
Will the tag “Fixes” become helpful for the commit message?

…
> +++ b/drivers/infiniband/sw/rdmavt/qp.c
> @@ -1203,6 +1203,7 @@  struct ib_qp *rvt_create_qp(struct ib_pd *ibpd,
>  			qp->s_flags = RVT_S_SIGNAL_REQ_WR;
>  		err = alloc_ud_wq_attr(qp, rdi->dparms.node);
>  		if (err) {
> +			rvt_free_rq(&qp->r_rq);
>  			ret = (ERR_PTR(err));
>  			goto bail_driver_priv;
>  		}

How do you think about the following code variant with the addition
of a jump target?

 		err = alloc_ud_wq_attr(qp, rdi->dparms.node);
 		if (err) {
 			ret = (ERR_PTR(err));
-			goto bail_driver_priv;
+			goto bail_free_rq;
 		}

…

 bail_rq_wq:
-	rvt_free_rq(&qp->r_rq);
 	free_ud_wq_attr(qp);
+
+bail_free_rq:
+	rvt_free_rq(&qp->r_rq);

 bail_driver_priv:


Regards,
Markus