linux-kernel - Re: [PATCH] Input: stmfts: fix ref count leak in stmfts_input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <5b0147ab-f0bc-7380-6300-90e555534cb4@web.de>
Date:   Sun, 14 Jun 2020 11:33:34 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Navid Emamdoost <navid.emamdoost@...il.com>,
        linux-arm-kernel@...ts.infradead.org, linux-input@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com
Cc:     Navid Emamdoost <emamd001@....edu>, Kangjie Lu <kjlu@....edu>,
        Stephen McCamant <smccaman@....edu>,
        Qiushi Wu <wu000273@....edu>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: stmfts: fix ref count leak in stmfts_input_open

> in stmfts_input_open, …

* Can the term “reference count” become relevant also for this commit message
  besides other possible adjustments?

* Would you like to add the tag “Fixes”?


…
> +++ b/drivers/input/touchscreen/stmfts.c
…
> @@ -367,6 +367,9 @@  static int stmfts_input_open(struct input_dev *dev)
>  	}
>
>  	return 0;
> +out:
> +	pm_runtime_put(&sdata->client->dev);
> +	return err;
>  }
…

Perhaps use the label “put_runtime” instead?

Regards,
Markus