lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 14 Jun 2020 12:48:06 +0300
From:   Andy Shevchenko <>
To:     Navid Emamdoost <>
Cc:     Lucas Stach <>,
        Russell King <>,
        Christian Gmeiner <>,
        David Airlie <>,
        Daniel Vetter <>,,
        dri-devel <>,
        Linux Kernel Mailing List <>,
        Navid Emamdoost <>,,
        Kangjie Lu <>, Stephen McCamant <>
Subject: Re: [PATCH] drm/etnaviv: fix ref count leak via pm_runtime_get_sync

On Sun, Jun 14, 2020 at 9:48 AM Navid Emamdoost
<> wrote:


> +               if (ret < 0) {

> +                       pm_runtime_put(gpu->dev);

Please, in all your patches fix this to be _put_noidle(). We wouldn't
bear the flag day of fixing these parts again.
Yes, I know that *now* behaviour is the same, but calling put here is
slightly inconsistent.


> +               pm_runtime_put(gpu->dev);

With Best Regards,
Andy Shevchenko

Powered by blists - more mailing lists