lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 14 Jun 2020 11:10:08 -0700
From:   James Bottomley <James.Bottomley@...senPartnership.com>
To:     zzuedu2000@....com, tj@...nel.org, lizefan@...wei.com,
        hannes@...xchg.org
Cc:     cgroups@...r.kernel.org, linux-kernel@...r.kernel.org,
        Markus.Elfring@....de, songmuchun@...edance.com,
        buddy.zhang@...yun.com
Subject: Re: [PATCH] cgroup: Refactor two assignments in
 css_task_iter_next_css_set()

On Sun, 2020-06-14 at 10:28 +0800, zzuedu2000@....com wrote:
> From: Wei Fenghai <zzuedu2000@....com>
> 
> Combine two assignments for the variable ā€˜lā€™ into one statement.

The problem with this commit message isn't the description, we can all
see what the change does, it's the justification.  Why is there any
reason to do this?  My version of gcc does this as an optimization
anyway, so the patch doesn't change to the binary output and it's
arguable that having two statements instead of one makes the code
marginally more readable.

Regards,

James

Powered by blists - more mailing lists