[<prev] [next>] [day] [month] [year] [list]
Message-ID: <3639cbd1-1ddc-2207-b119-b6a45723be04@web.de>
Date: Mon, 15 Jun 2020 18:18:36 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Navid Emamdoost <navid.emamdoost@...il.com>,
linux-input@...r.kernel.org
Cc: Navid Emamdoost <emamd001@....edu>, Kangjie Lu <kjlu@....edu>,
Stephen McCamant <mccamant@...umn.edu>,
Qiushi Wu <wu000273@....edu>, linux-kernel@...r.kernel.org,
kernel-janitors@...r.kernel.org,
Andy Shevchenko <andy.shevchenko@...il.com>,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
Jonathan Bakker <xc-racer2@...e.ca>,
Paweł Chmiel <pawel.mikolaj.chmiel@...il.com>
Subject: Re: [PATCH v2] Input: bma150: fix ref count leak in bma150_open
> in bma150_open, …
* Can the term “reference count” become relevant also for this commit message
besides other possible adjustments?
* Would you like to add the tag “Fixes”?
…
> +++ b/drivers/input/misc/bma150.c
…
> @@ -357,10 +357,13 @@ static int bma150_open(struct input_dev *input)
> if (bma150->mode != BMA150_MODE_NORMAL) {
> error = bma150_set_mode(bma150, BMA150_MODE_NORMAL);
> if (error)
> - return error;
> + goto out;
> }
>
> return 0;
> +out:
> + pm_runtime_put_noidle(&bma150->client->dev);
> + return error;
> }
…
Perhaps use the label “put_runtime” instead?
Regards,
Markus
Powered by blists - more mailing lists