linux-kernel - Re: [PATCH v3] f2fs: use kfree() instead of kvfree() to free superblock data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200615175800.GA117170@google.com>
Date:   Mon, 15 Jun 2020 10:58:00 -0700
From:   Jaegeuk Kim <jaegeuk@...nel.org>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     Denis Efremov <efremov@...ux.com>, Chao Yu <yuchao0@...wei.com>,
        linux-kernel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [PATCH v3] f2fs: use kfree() instead of kvfree() to free
 superblock data

On 06/09, Eric Biggers wrote:
> On Wed, Jun 10, 2020 at 01:14:46AM +0300, Denis Efremov wrote:
> > Use kfree() instead of kvfree() to free super in read_raw_super_block()
> > because the memory is allocated with kzalloc() in the function.
> > Use kfree() instead of kvfree() to free sbi, raw_super in
> > f2fs_fill_super() and f2fs_put_super() because the memory is allocated
> > with kzalloc().
> > 
> > Fixes: 5222595d093e ("f2fs: use kvmalloc, if kmalloc is failed")
> > Signed-off-by: Denis Efremov <efremov@...ux.com>
> 
> I don't think "Fixes" is appropriate here.

Agreed. I queued this Cl without it. :)
Thanks,

> 
> kvfree() still works on kmalloc'ed memory; it's just not preferred.
> 
> So this is more a cleanup than a fix.
> 
> - Eric