linux-kernel - Re: [PATCH] Input: bma150: fix ref count leak in bma150

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEkB2ES7SjV8JMb8MAO9CWhg=_VekQehF+NxxYs6e6=xySUEBw@mail.gmail.com>
Date:   Mon, 15 Jun 2020 01:36:28 -0500
From:   Navid Emamdoost <navid.emamdoost@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Jonathan Bakker <xc-racer2@...e.ca>,
        Paweł Chmiel <pawel.mikolaj.chmiel@...il.com>,
        linux-input <linux-input@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Navid Emamdoost <emamd001@....edu>,
        Qiushi Wu <wu000273@....edu>, Kangjie Lu <kjlu@....edu>,
        Stephen McCamant <smccaman@....edu>
Subject: Re: [PATCH] Input: bma150: fix ref count leak in bma150_open

On Sun, Jun 14, 2020 at 4:27 AM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
> On Sun, Jun 14, 2020 at 8:58 AM Navid Emamdoost
> <navid.emamdoost@...il.com> wrote:
> >
> > in bma150_open, pm_runtime_get_sync is called which
> > increments the counter even in case of failure, leading to incorrect
> > ref count. In case of failure, decrement the ref count before returning.
>
> ...
>
> >         error = pm_runtime_get_sync(&bma150->client->dev);
> >         if (error < 0 && error != -ENOSYS)
> > -               return error;
> > +               goto out;
>
> So, what will happen in case of -ENOSYS?
I'm not sure!

>
> ...
>
> > +       pm_runtime_put(&bma150->client->dev);
>
> Slightly better to use _put_noidle(). (More consistency with error path)

v2 is sent.

>
> --
> With Best Regards,
> Andy Shevchenko



-- 
Navid.