linux-kernel - Re: [PATCH] net: fec: fix ref count leaking when pm_runtime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200615.134216.1492983787088475104.davem@davemloft.net>
Date:   Mon, 15 Jun 2020 13:42:16 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     navid.emamdoost@...il.com
Cc:     fugang.duan@....com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, emamd001@....edu, wu000273@....edu,
        kjlu@....edu, mccamant@...umn.edu
Subject: Re: [PATCH] net: fec: fix ref count leaking when
 pm_runtime_get_sync fails

From: Navid Emamdoost <navid.emamdoost@...il.com>
Date: Sun, 14 Jun 2020 00:38:01 -0500

> in fec_enet_mdio_read, fec_enet_mdio_write, fec_enet_get_regs,
> fec_enet_open and fec_drv_remove, pm_runtime_get_sync is called which
> increments the counter even in case of failure, leading to incorrect
> ref count. In case of failure, decrement the ref count before returning.
> 
> Signed-off-by: Navid Emamdoost <navid.emamdoost@...il.com>

This does not apply to the net tree.