linux-kernel - Re: [PATCH v3 1/3] net: phy: mscc: move shared probe code into a helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 Jun 2020 04:56:21 +0800
From:   kernel test robot <lkp@...el.com>
To:     Heiko Stuebner <heiko@...ech.de>, davem@...emloft.net,
        kuba@...nel.org
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        robh+dt@...nel.org, andrew@...n.ch, f.fainelli@...il.com,
        hkallweit1@...il.com, linux@...linux.org.uk,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/3] net: phy: mscc: move shared probe code into a
 helper

Hi Heiko,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]
[also build test WARNING on sparc-next/master net/master linus/master v5.8-rc1 next-20200615]
[cannot apply to robh/for-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Heiko-Stuebner/net-phy-mscc-move-shared-probe-code-into-a-helper/20200615-224727
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git cb8e59cc87201af93dfbb6c3dccc8fcad72a09c2
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 3d8149c2a1228609fd7d7c91a04681304a2f0ca9)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/net/phy/mscc/mscc_main.c:2002:10: warning: variable 'vsc8531' is uninitialized when used here [-Wuninitialized]
vsc8531->base_addr, 0);
^~~~~~~
drivers/net/phy/mscc/mscc_main.c:1986:33: note: initialize the variable 'vsc8531' to silence this warning
struct vsc8531_private *vsc8531;
^
= NULL
1 warning generated.

vim +/vsc8531 +2002 drivers/net/phy/mscc/mscc_main.c

  1983	
  1984	static int vsc8574_probe(struct phy_device *phydev)
  1985	{
  1986		struct vsc8531_private *vsc8531;
  1987		int rc;
  1988		u32 default_mode[4] = {VSC8531_LINK_1000_ACTIVITY,
  1989		   VSC8531_LINK_100_ACTIVITY, VSC8531_LINK_ACTIVITY,
  1990		   VSC8531_DUPLEX_COLLISION};
  1991	
  1992		rc = vsc85xx_probe_helper(phydev, default_mode,
  1993					  ARRAY_SIZE(default_mode),
  1994					  VSC8584_SUPP_LED_MODES,
  1995					  vsc8584_hw_stats,
  1996					  ARRAY_SIZE(vsc8584_hw_stats));
  1997		if (rc < 0)
  1998			return rc;
  1999	
  2000		vsc8584_get_base_addr(phydev);
  2001		return devm_phy_package_join(&phydev->mdio.dev, phydev,
> 2002					     vsc8531->base_addr, 0);
  2003	}
  2004	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (73919 bytes)