lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Jun 2020 09:11:27 +0800 From: Zefan Li <lizefan@...wei.com> To: <zzuedu2000@....com>, <James.Bottomley@...senPartnership.com> CC: <tj@...nel.org>, <hannes@...xchg.org>, <cgroups@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <Markus.Elfring@....de>, <songmuchun@...edance.com>, <buddy.zhang@...yun.com> Subject: Re: [PATCH] cgroup: Refactor two assignments in css_task_iter_next_css_set() On 2020/6/15 7:22, zzuedu2000@....com wrote: > On Sun, 2020-06-14 at 18:10 +0800, James.Bottomley@...xxxx wrote: > >> it's arguable that having two statements instead of one makes the code >> marginally more readable. > > Above the function there is a similar line of code: > l = it->tcset_pos->next; > One line of code makes the code style consistent and more readable > It would be much better if you are fixing a bug or developing a new feature and while at it you do this cleanup conveniently, but this patch alone has little value.
Powered by blists - more mailing lists