lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Jun 2020 19:24:53 -0400 From: Sasha Levin <sashal@...nel.org> To: Linus Torvalds <torvalds@...ux-foundation.org> Cc: Shuah Khan <skhan@...uxfoundation.org>, Konstantin Khlebnikov <koct9i@...il.com>, Joerg Roedel <jroedel@...e.de>, Andrew Lutomirski <luto@...nel.org>, Peter Zijlstra <peterz@...radead.org>, Takashi Iwai <tiwai@...e.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, the arch/x86 maintainers <x86@...nel.org> Subject: Re: [PATCH] scripts/decode_stacktrace: warn when modpath is needed but is unset On Mon, Jun 15, 2020 at 03:43:31PM -0700, Linus Torvalds wrote: >On Mon, Jun 15, 2020 at 3:37 PM Linus Torvalds ><torvalds@...ux-foundation.org> wrote: >> >> Well, that looks straightforward. > >Hmm. Decided to test it. It warns for every case: a bit excessive, >perhaps, but I guess it won't hurt. > >So Shuah's thing results in > >[ 9.791367] Call Trace: >WARNING! Modules path isn't set, but is needed to parse this symbol >[ 9.791377] ? snd_pcm_hw_params+0x3ca/0x440 snd_pcm >WARNING! Modules path isn't set, but is needed to parse this symbol >[ 9.791383] snd_pcm_common_ioctl+0x173/0xf20 snd_pcm >WARNING! Modules path isn't set, but is needed to parse this symbol >[ 9.791389] ? snd_ctl_ioctl+0x1c5/0x710 snd >WARNING! Modules path isn't set, but is needed to parse this symbol >[ 9.791394] snd_pcm_ioctl+0x27/0x40 snd_pcm > >which looks a bit redundant, but maybe that just means people _really_ notice. I figured it's a good balance between warning only once (which can get lost in a longer trace) vs just exiting on error (as it prevents the user from ignoring this issue if he doesn't care or just doesn't have the modules). -- Thanks, Sasha
Powered by blists - more mailing lists