linux-kernel - Re: drivers/net/can/kvaser_pciefd.c:801:17: sparse: sparse: cast removes address space '<asn:2>' of expression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <044ff868-00f1-90a4-25e6-9f62f7a042ad@linux-m68k.org>
Date:   Mon, 15 Jun 2020 17:07:13 +1000
From:   Greg Ungerer <gerg@...ux-m68k.org>
To:     Luc Van Oostenryck <luc.vanoostenryck@...il.com>
Cc:     Marc Kleine-Budde <mkl@...gutronix.de>,
        kernel test robot <lkp@...el.com>,
        Henning Colliander <henning.colliander@...dente.se>,
        kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Jimmy Assarsson <extja@...ser.com>,
        Christer Beskow <chbe@...ser.com>
Subject: Re: drivers/net/can/kvaser_pciefd.c:801:17: sparse: sparse: cast
 removes address space '<asn:2>' of expression


On 13/6/20 2:35 am, Luc Van Oostenryck wrote:
> On Sat, Jun 13, 2020 at 01:33:16AM +1000, Greg Ungerer wrote:
>>>>      arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>>
>> This one I am not sure about yet.
>> Still investigating.
> 
> 	swab32(__raw_readl(addr)) ?
> 
> Keeping __le32_to_cpu() will only force you to use ugly casts for no benefits
> and the comment above explain clearly the situation about the endianness.

That is unfortunate, the use of le32_to_cpu() made it very clear
what was going on - for those that don't choose to read comments.

In any case that would seem to be the cleanest solution.
Patch to follow.

Regards
Greg