linux-kernel - Re: [Patch] mtd: set master partition panic write flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200615092221.7f269810@xps13>
Date:   Mon, 15 Jun 2020 09:22:21 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Kamal Dasu <kdasu.kdev@...il.com>
Cc:     Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        bcm-kernel-feedback-list@...adcom.com,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [Patch] mtd: set master partition panic write flag

Hi Kamal,

Kamal Dasu <kdasu.kdev@...il.com> wrote on Sat, 13 Jun 2020 02:49:31
-0400:

> Can you please accept this if there are no objections.
> 
> Kamal
> 
> > On May 4, 2020, at 7:54 PM, Kamal Dasu <kdasu.kdev@...il.com> wrote:
> > 
> > Check and set master panic write flag so that low level drivers
> > can use it to take required action to ensure oops data gets written
> > to assigned mtdoops device partition.
> > 
> > Signed-off-by: Kamal Dasu <kdasu.kdev@...il.com>
> > ---
> > drivers/mtd/mtdcore.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> > index 2916674208b3..7e37ed2f38ea 100644
> > --- a/drivers/mtd/mtdcore.c
> > +++ b/drivers/mtd/mtdcore.c
> > @@ -1235,8 +1235,8 @@ int mtd_panic_write(struct mtd_info *mtd, loff_t to, size_t len, size_t *retlen,
> >        return -EROFS;
> >    if (!len)
> >        return 0;
> > -    if (!mtd->oops_panic_write)
> > -        mtd->oops_panic_write = true;
> > +    if (!master->oops_panic_write)
> > +        master->oops_panic_write = true;
> > 
> >    return master->_panic_write(master, mtd_get_master_ofs(mtd, to), len,
> >                    retlen, buf);
> > -- 
> > 2.17.1
> >   

I thing we missed it. However, shouldn't we have a Cc:/Fixes: pair of
tags here? We could send it as part of a fixes PR then.

Thanks,
Miquèl