linux-kernel - Re: [PATCH] csky: remove unusued thread_saved_pc and *

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 Jun 2020 10:43:15 +0200
From:   Tobias Klauser <tklauser@...tanz.ch>
To:     Guo Ren <guoren@...nel.org>
Cc:     Mao Han <han_mao@...ky.com>, linux-csky@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] csky: remove unusued thread_saved_pc and *_segments
 functions/macros

On 2020-06-13 at 10:42:07 +0200, Guo Ren <guoren@...nel.org> wrote:
> Acked-by: Guo Ren <guoren@...nel.org>

Thanks for the Ack. Are you taking this patch through your own tree or
should I directly submit to someone else?

> On Wed, Jun 10, 2020 at 11:45 PM Tobias Klauser <tklauser@...tanz.ch> wrote:
> >
> > These are used nowhere in the tree (except for some architectures which
> > define them for their own use) and were already removed for other
> > architectures in:
> >
> > commit 6474924e2b5d ("arch: remove unused macro/function thread_saved_pc()")
> > commit c17c02040bf0 ("arch: remove unused *_segments() macros/functions")
> >
> > Remove them from arch/csky as well.
> >
> > Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>
> > ---
> >  arch/csky/include/asm/processor.h |  6 ------
> >  arch/csky/kernel/process.c        | 10 ----------
> >  2 files changed, 16 deletions(-)
> >
> > diff --git a/arch/csky/include/asm/processor.h b/arch/csky/include/asm/processor.h
> > index 24442d8e86f9..4800f6563abb 100644
> > --- a/arch/csky/include/asm/processor.h
> > +++ b/arch/csky/include/asm/processor.h
> > @@ -82,12 +82,6 @@ static inline void release_thread(struct task_struct *dead_task)
> >
> >  extern int kernel_thread(int (*fn)(void *), void *arg, unsigned long flags);
> >
> > -#define copy_segments(tsk, mm)         do { } while (0)
> > -#define release_segments(mm)           do { } while (0)
> > -#define forget_segments()              do { } while (0)
> > -
> > -extern unsigned long thread_saved_pc(struct task_struct *tsk);
> > -
> >  unsigned long get_wchan(struct task_struct *p);
> >
> >  #define KSTK_EIP(tsk)          (task_pt_regs(tsk)->pc)
> > diff --git a/arch/csky/kernel/process.c b/arch/csky/kernel/process.c
> > index 8b3fad062ab2..3da63cf0bfde 100644
> > --- a/arch/csky/kernel/process.c
> > +++ b/arch/csky/kernel/process.c
> > @@ -30,16 +30,6 @@ asmlinkage void ret_from_kernel_thread(void);
> >   */
> >  void flush_thread(void){}
> >
> > -/*
> > - * Return saved PC from a blocked thread
> > - */
> > -unsigned long thread_saved_pc(struct task_struct *tsk)
> > -{
> > -       struct switch_stack *sw = (struct switch_stack *)tsk->thread.sp;
> > -
> > -       return sw->r15;
> > -}
> > -
> >  int copy_thread_tls(unsigned long clone_flags,
> >                 unsigned long usp,
> >                 unsigned long kthread_arg,
> > --
> > 2.27.0
> >
> 
> 
> -- 
> Best Regards
>  Guo Ren
> 
> ML: https://lore.kernel.org/linux-csky/
>