[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <39ad93ee-236d-0e5e-571a-28ef91173309@linaro.org>
Date: Mon, 15 Jun 2020 10:56:55 +0100
From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To: Ravi Kumar Bokka <rbokka@...eaurora.org>,
Rob Herring <robh+dt@...nel.org>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
rnayak@...eaurora.org, saiprakash.ranjan@...eaurora.org,
dhavalp@...eaurora.org, mturney@...eaurora.org,
sparate@...eaurora.org, c_rbokka@...eaurora.org,
mkurumel@...eaurora.org
Subject: Re: [RFC v2 2/3] drivers: nvmem: Add QTI qfprom-efuse support
I think Doug already covered most of the comments and his fixes seems be
in right direction.
On 11/06/2020 10:48, Ravi Kumar Bokka wrote:
> + qfpraw = platform_get_resource_byname(pdev, IORESOURCE_MEM, "raw");
> +
> + priv->qfpraw = devm_ioremap_resource(dev, qfpraw);
> + if (IS_ERR(priv->qfpraw)) {
General comment for up-streaming is that your patch should not break
whats in mainline, Your patch is totally ignoring!! Please be mindful
while doing changes to drivers which are used by other platforms.
--srini
> + ret = PTR_ERR(priv->qfpraw);
> + goto err;
> + }
> +
> + qfpconf = platform_get_resource_byname(pdev, IORESOURCE_MEM, "conf");
> +
> + priv->qfpconf = devm_ioremap_resource(dev, qfpconf);
> + if (IS_ERR(priv->qfpconf)) {
> + ret = PTR_ERR(priv->qfpconf);
> + goto err;
> + }
> +
> + qfpcorrected = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> + "corrected");
> +
> + priv->qfpcorrected = devm_ioremap_resource(dev, qfpcorrected);
> + if (IS_ERR(priv->qfpcorrected)) {
> + ret = PTR_ERR(priv->qfpcorrected);
> + goto err;
> + }
Powered by blists - more mailing lists