linux-kernel - Re: [PATCH] objtool: Free memory in error case in special_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.21.2006151238390.5945@pobox.suse.cz>
Date:   Mon, 15 Jun 2020 12:40:32 +0200 (CEST)
From:   Miroslav Benes <mbenes@...e.cz>
To:     Tobias Klauser <tklauser@...tanz.ch>
cc:     Josh Poimboeuf <jpoimboe@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] objtool: Free memory in error case in special_get_alts

Hi,

On Fri, 12 Jun 2020, Tobias Klauser wrote:

> Avoid a memory leak in case get_alt_entry returns an error.

yes, this is not the only one, but I doubt we want to spend time on that. 
The process is about to exit anyway.

Miroslav

> Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>
> ---
>  tools/objtool/special.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/objtool/special.c b/tools/objtool/special.c
> index e74e0189de22..f6f7dee1ba77 100644
> --- a/tools/objtool/special.c
> +++ b/tools/objtool/special.c
> @@ -188,8 +188,10 @@ int special_get_alts(struct elf *elf, struct list_head *alts)
>  			memset(alt, 0, sizeof(*alt));
>  
>  			ret = get_alt_entry(elf, entry, sec, idx, alt);
> -			if (ret)
> +			if (ret) {
> +				free(alt);
>  				return ret;
> +			}
>  
>  			list_add_tail(&alt->list, alts);
>  		}
> -- 
> 2.27.0
>