linux-kernel - Re: [PATCH 0/3] Convert nsproxy, groups, and creds to refcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202006142054.C00B3E9C9@keescook>
Date:   Sun, 14 Jun 2020 20:55:49 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Xiaoming Ni <nixiaoming@...wei.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        David Windsor <dwindsor@...il.com>,
        Hans Liljestrand <ishkamiel@...il.com>,
        Elena Reshetova <elena.reshetova@...el.com>,
        Paul Moore <paul@...l-moore.com>, edumazet@...gle.com,
        paulmck@...nel.org, David Howells <dhowells@...hat.com>,
        shakeelb@...gle.com, James Morris <jamorris@...ux.microsoft.com>,
        alex.huangjianhui@...wei.com, dylix.dailei@...wei.com,
        chenzefeng2@...wei.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] Convert nsproxy, groups, and creds to refcount_t

On Mon, Jun 15, 2020 at 10:10:08AM +0800, Xiaoming Ni wrote:
> On 2020/6/13 2:34, Kees Cook wrote:
> > This series was never applied[1], and was recently pointed out as
> > missing[2]. If someone has a tree for this, please take it. Otherwise,
> > please Ack and I'll send it to Linus.
> > 
> > Thanks!
> > 
> > -Kees
> > 
> > [1] https://lore.kernel.org/lkml/20190306110549.7628-1-elena.reshetova@intel.com/
> > [2] https://lore.kernel.org/lkml/1591957695-118312-1-git-send-email-nixiaoming@huawei.com/
> > 
> > Elena Reshetova (3):
> >    nsproxy: convert nsproxy.count to refcount_t
> >    groups: convert group_info.usage to refcount_t
> >    creds: convert cred.usage to refcount_t
> > 
> >   include/linux/cred.h    | 15 +++++++-------
> >   include/linux/nsproxy.h |  7 +++----
> >   kernel/cred.c           | 44 ++++++++++++++++++++---------------------
> >   kernel/groups.c         |  2 +-
> >   kernel/nsproxy.c        |  6 +++---
> >   net/sunrpc/auth.c       |  2 +-
> >   6 files changed, 38 insertions(+), 38 deletions(-)
> > 
> 
> Should mm->mm_users also be replaced by refcount_t?

I'll say "yes". :)
https://lore.kernel.org/lkml/1487671124-11188-1-git-send-email-elena.reshetova@intel.com/

> In addition, is it better to change all variables that use
> atomic_dec_and_test to control the release process to refconut_t?

For the most part, yes. The following may find a lot of them:
scripts/coccinelle/api/atomic_as_refcounter.cocci

If you can go through that and double check for prior series from Elena,
we can get through all the rest of them.

Thanks for bringing this topic back up!

-- 
Kees Cook