linux-kernel - Re: [RFC PATCH] serial: samsung: Re-factors UART IRQ resource for various Samsung SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200615125045.GA946844@kroah.com>
Date:   Mon, 15 Jun 2020 14:50:45 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Tamseel Shams <m.shams@...sung.com>
Cc:     kgene@...nel.org, krzk@...nel.org, jslaby@...e.com,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org, alim.akhtar@...sung.com
Subject: Re: [RFC PATCH] serial: samsung: Re-factors UART IRQ resource for
 various Samsung SoC

On Mon, Jun 15, 2020 at 05:56:09PM +0530, Tamseel Shams wrote:
> In few older Samsung SoCs like s3c2410, s3c2412
> and s3c2440, UART IP is having 2 interrupt lines.
> However, in other SoCs like s3c6400, s5pv210,
> exynos5433, and exynos4210 UART is having only 1
> interrupt line. Due to this, "platform_get_irq(platdev, 1)"
> call in the driver gives the following warning:
> "IRQ index 1 not found" on recent platforms.
> 
> This patch re-factors the IRQ resources handling for
> each platform and hence fixing the above warnings seen
> on some platforms.
> 
> Signed-off-by: Tamseel Shams <m.shams@...sung.com>
> ---
>  drivers/tty/serial/samsung_tty.c | 20 ++++++++++++++++----
>  1 file changed, 16 insertions(+), 4 deletions(-)

RFC means "I do not trust this so I don't want anyone to merge it", so
I'll just delete it from my queue and wait for you to come up with
something that you feel confident with :)

thanks,

greg k-h