linux-kernel - Re: [PATCH 4.19 11/25] iio: vcnl4000: Fix i2c swapped word reading.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 Jun 2020 15:30:18 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Mathieu Othacehe <m.othacehe@...il.com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH 4.19 11/25] iio: vcnl4000: Fix i2c swapped word reading.

Hi!

> From: Mathieu Othacehe <m.othacehe@...il.com>
> 
> commit 18dfb5326370991c81a6d1ed6d1aeee055cb8c05 upstream.
> 
> The bytes returned by the i2c reading need to be swapped
> unconditionally. Otherwise, on be16 platforms, an incorrect value will be
> returned.
> 
> Taking the slow path via next merge window as its been around a while
> and we have a patch set dependent on this which would be held up.

Is there some explanation how this is correct Somewhere? I assume i2c
hardware has fixed endianity (not depending on CPU), so unconditional
swapping will cause problems either on le or on be machines...?

Best regards,
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)