linux-kernel - Re: [PATCH 0/8] x86/entry: KCSAN/KASAN/UBSAN vs noinstr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200615150639.GX2531@hirez.programming.kicks-ass.net>
Date:   Mon, 15 Jun 2020 17:06:39 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Qian Cai <cai@....pw>
Cc:     Marco Elver <elver@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        the arch/x86 maintainers <x86@...nel.org>,
        "Paul E. McKenney" <paulmck@...nel.org>,
        kasan-dev <kasan-dev@...glegroups.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Will Deacon <will@...nel.org>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Alexander Potapenko <glider@...gle.com>,
        Andrey Konovalov <andreyknvl@...gle.com>
Subject: Re: [PATCH 0/8] x86/entry: KCSAN/KASAN/UBSAN vs noinstr

On Mon, Jun 15, 2020 at 10:57:18AM -0400, Qian Cai wrote:
> On Mon, Jun 15, 2020 at 12:07:34PM +0200, 'Marco Elver' via kasan-dev wrote:
> > On Thu, 4 Jun 2020 at 13:01, Marco Elver <elver@...gle.com> wrote:
> > >
> > > On Thu, 4 Jun 2020 at 12:25, Peter Zijlstra <peterz@...radead.org> wrote:
> > > >
> > > > Hai,
> > > >
> > > > Here's the remaining few patches to make KCSAN/KASAN and UBSAN work with noinstr.
> > >
> > > Thanks for assembling the series!
> > >
> > > For where it's missing (1,2,3 and last one):
> > >
> > > Acked-by: Marco Elver <elver@...gle.com>
> > 
> > Where was this series supposed to go? I can't find it on any tree yet.
> > 
> > How urgent is this? Boot-test seems fine without this, but likely
> > doesn't hit the corner cases. Syzbot will likely find them, and if we
> > noticeably end up breaking various sanitizers without this, I'd
> > consider this urgent.
> 
> Today's linux-next had a lot of those with this .config,
> 
> https://raw.githubusercontent.com/cailca/linux-mm/master/x86.config
> 
> Wondering if this patchset will cure them all?

Many, not all, you also need:

  https://lkml.kernel.org/r/20200603114051.896465666@infradead.org

and then I think you're down to only 1 kasan thing. But also read this
thread:

  https://lkml.kernel.org/r/20200611215812.GF4496@worktop.programming.kicks-ass.net

latest version of that actual patch here:

  https://lkml.kernel.org/r/20200612143034.933422660@infradead.org