linux-kernel - Re: [PATCH] ARM: dts: am5729: beaglebone-ai: fix rgmii phy-mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6a7eb03a-933b-0f04-a42d-a457f3fa1d9f@ti.com>
Date:   Mon, 15 Jun 2020 18:22:10 +0300
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Drew Fustini <drew@...gleboard.org>
CC:     Tony Lindgren <tony@...mide.com>, Rob Herring <robh+dt@...nel.org>,
        Linux-OMAP <linux-omap@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Jason Kridner <jkridner@...gleboard.org>,
        Robert Nelson <robertcnelson@...il.com>,
        Vinod Koul <vkoul@...nel.org>
Subject: Re: [PATCH] ARM: dts: am5729: beaglebone-ai: fix rgmii phy-mode



On 15/06/2020 15:45, Drew Fustini wrote:
> On Mon, Jun 15, 2020 at 12:34:57PM +0300, Grygorii Strashko wrote:
>>
>>
>> On 12/06/2020 01:09, Drew Fustini wrote:
>>> Since commit cd28d1d6e52e ("net: phy: at803x: Disable phy delay for
>>> RGMII mode") the networking is broken on the BeagleBone AI which has
>>> the AR8035 PHY for Gigabit Ethernet [0].  The fix is to switch from
>>> phy-mode = "rgmii" to phy-mode = "rgmii-rxid".
>>>
>>> Note: Grygorii Strashko made a similar phy-mode fix in 820f8a870f65 for
>>> other AM5729 boards.
>>
>> commit ref is incorrect
> 
> Do you mean commit ref 820f8a870f65 ?
> ("ARM: dts: am57xx: fix networking on boards with ksz9031 phy")
> 
> I thought it made sense to point to that commit as you seemed to be
> fixing a very similar issue, just for a different phy.

Yes. but you should use proper format for commit ref:
commit <12+ chars of sha1> (\"<title line>\")'

checkpatch should warn you.




-- 
Best regards,
grygorii