[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200615153052.GY2531@hirez.programming.kicks-ass.net>
Date: Mon, 15 Jun 2020 17:30:52 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: "Paul E. McKenney" <paulmck@...nel.org>
Cc: tglx@...utronix.de, x86@...nel.org, elver@...gle.com,
kasan-dev@...glegroups.com, linux-kernel@...r.kernel.org,
will@...nel.org, dvyukov@...gle.com, glider@...gle.com,
andreyknvl@...gle.com
Subject: Re: [PATCH 2/9] rcu: Fixup noinstr warnings
On Wed, Jun 03, 2020 at 09:46:00AM -0700, Paul E. McKenney wrote:
> > // RCU is now watching. Better not be in an extended quiescent state!
> > rcu_dynticks_task_trace_exit(); // After ->dynticks update!
> > WARN_ON_ONCE(IS_ENABLED(CONFIG_RCU_EQS_DEBUG) &&
> > !(seq & RCU_DYNTICK_CTRL_CTR));
> > if (seq & RCU_DYNTICK_CTRL_MASK) {
> > - atomic_andnot(RCU_DYNTICK_CTRL_MASK, &rdp->dynticks);
> > + arch_atomic_andnot(RCU_DYNTICK_CTRL_MASK, &rdp->dynticks);
>
> This one is gone in -rcu.
I'm still seeing that in mainline, was that removal scheduled for next
round?
> > smp_mb__after_atomic(); /* _exit after clearing mask. */
> > }
> > }
What shall we do with this patch?
Powered by blists - more mailing lists