linux-kernel - Re: [PATCH v2 4/6] regulator: Add support for QCOM PMIC VBUS booster

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b8fe3da7-4494-7d7e-f5f1-f94826ebb831@codeaurora.org>
Date:   Mon, 15 Jun 2020 21:21:24 -0700
From:   Wesley Cheng <wcheng@...eaurora.org>
To:     Randy Dunlap <rdunlap@...radead.org>, robh+dt@...nel.org,
        heikki.krogerus@...ux.intel.com, gregkh@...uxfoundation.org,
        mark.rutland@....com, broonie@...nel.org, lgirdwood@...il.com,
        agross@...nel.org, bjorn.andersson@...aro.org
Cc:     linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-usb@...r.kernel.org,
        lijun.kernel@...il.com, jackp@...eaurora.org,
        bryan.odonoghue@...aro.org
Subject: Re: [PATCH v2 4/6] regulator: Add support for QCOM PMIC VBUS booster



On 6/12/2020 8:28 PM, Randy Dunlap wrote:
> On 6/12/20 4:19 PM, Wesley Cheng wrote:
>> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
>> index 074a2ef55943..f9165f9f9051 100644
>> --- a/drivers/regulator/Kconfig
>> +++ b/drivers/regulator/Kconfig
>> @@ -797,6 +797,16 @@ config REGULATOR_QCOM_SPMI
>>  	  Qualcomm SPMI PMICs as a module. The module will be named
>>  	  "qcom_spmi-regulator".
>>  
>> +config REGULATOR_QCOM_USB_VBUS
>> +	tristate "Qualcomm USB Vbus regulator driver"
>> +	depends on SPMI || COMPILE_TEST
>> +	help
>> +	  If you say yes to this option, support will be included for the
>> +	  regulator used to enable the VBUS output.
>> +
>> +	  Say M here if you want to include support for enabling the VBUS output
>> +	  as a module. The module will be named "qcom_usb-regulator".
> 
> Hi,
> Shouldn't that module name match what is in the Makefile?
> 
> 

Thanks, Randy.  Missed this as I was going back and forth on the file
name.  Thanks for the catch.

>> +
>>  config REGULATOR_RC5T583
>>  	tristate "RICOH RC5T583 Power regulators"
>>  	depends on MFD_RC5T583
>> diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile
>> index c0d6b96ebd78..cbab28aa7b56 100644
>> --- a/drivers/regulator/Makefile
>> +++ b/drivers/regulator/Makefile
>> @@ -89,6 +89,7 @@ obj-$(CONFIG_REGULATOR_QCOM_RPM) += qcom_rpm-regulator.o
>>  obj-$(CONFIG_REGULATOR_QCOM_RPMH) += qcom-rpmh-regulator.o
>>  obj-$(CONFIG_REGULATOR_QCOM_SMD_RPM) += qcom_smd-regulator.o
>>  obj-$(CONFIG_REGULATOR_QCOM_SPMI) += qcom_spmi-regulator.o
>> +obj-$(CONFIG_REGULATOR_QCOM_USB_VBUS) += qcom_usb_vbus-regulator.o
>>  obj-$(CONFIG_REGULATOR_PALMAS) += palmas-regulator.o
>>  obj-$(CONFIG_REGULATOR_PFUZE100) += pfuze100-regulator.o
>>  obj-$(CONFIG_REGULATOR_PV88060) += pv88060-regulator.o
> 
> 
> thanks.
> 

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project