linux-kernel - Re: [RESEND PATCH] dmaengine: mmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200616162839.GL2324254@vkoul-mobl>
Date:   Tue, 16 Jun 2020 21:58:39 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Lubomir Rintel <lkundrak@...sk>
Cc:     Dan Williams <dan.j.williams@...el.com>, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] dmaengine: mmp_tdma: share the IRQ line

On 01-06-20, 21:22, Lubomir Rintel wrote:
> On a MMP2, the DMA interrupt is shared by all channels of the peripheral
> DMA controller and the audio DMA controller. Both drivers can identify
> their interrupts, but only the PDMA driver marks the line shared:
> 
>   [    1.185782] mmp-pdma d4000000.dma: initialized 16 channels
>   [    1.186808] mmp-tdma d42a0800.adma: IRQ index 1 not found
>   [    1.194317] genirq: Flags mismatch irq 64. 00000000 (tdma) vs. 00000080 (pdma)
>   [    1.197894] mmp-tdma: probe of d42a0800.adma failed with error -16
> 
> Let's turn on IRQF_SHARED in the ADMA driver as well.

Applied, thanks

-- 
~Vinod