linux-kernel - Re: [PATCH] btrfs: Use kfree() in btrfs_ioctl_get_subvol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200616171150.GH27795@twin.jikos.cz>
Date:   Tue, 16 Jun 2020 19:11:50 +0200
From:   David Sterba <dsterba@...e.cz>
To:     Waiman Long <longman@...hat.com>
Cc:     Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>,
        David Sterba <dsterba@...e.com>, linux-kernel@...r.kernel.org,
        linux-btrfs@...r.kernel.org
Subject: Re: [PATCH] btrfs: Use kfree() in btrfs_ioctl_get_subvol_info()

On Tue, Jun 16, 2020 at 11:31:59AM -0400, Waiman Long wrote:
> In btrfs_ioctl_get_subvol_info(), there is a classic case where kzalloc()
> was incorrectly paired with kzfree(). According to David Sterba, there
> isn't any sensitive information in the subvol_info that needs to be
> cleared before freeing. So kzfree() isn't really needed, use kfree()
> instead.
> 
> Reported-by: David Sterba <dsterba@...e.cz>
> Signed-off-by: Waiman Long <longman@...hat.com>

Added to the devel patch queue, thanks.