linux-kernel - Re: [RESENDx2][PATCH] sound: qcom: Kconfig: Tweak dependencies on SND_SOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200616183318.GW4447@sirena.org.uk>
Date:   Tue, 16 Jun 2020 19:33:19 +0100
From:   Mark Brown <broonie@...nel.org>
To:     John Stultz <john.stultz@...aro.org>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Rohit kumar <rohitkr@...eaurora.org>,
        Patrick Lai <plai@...eaurora.org>,
        Banajit Goswami <bgoswami@...eaurora.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Linux-ALSA <alsa-devel@...a-project.org>
Subject: Re: [RESENDx2][PATCH] sound: qcom: Kconfig: Tweak dependencies on
 SND_SOC_SDM845

On Tue, Jun 16, 2020 at 11:01:02AM -0700, John Stultz wrote:
> On Tue, Jun 16, 2020 at 1:25 AM Srinivas Kandagatla

> > > +     select SND_SOC_CROS_EC_CODEC if CROS_EC

> > Isn't "imply SND_SOC_CROS_EC_CODEC" better option here?

> I've honestly not gotten my head around "imply", so I'll have to take
> a closer look.
> What I have in this patch least is easier to compare and match with
> the existing code. :)

It's a conditional select which enables a Kconfig symbol if its
dependencies are enabled rather than forcing it on regardless of them,
avoiding most of the errors that select tends to introduce with missing
dependencies.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)