linux-kernel - [PATCH 1/2] nsproxy: restore EINVAL for non-namespace file descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200616225612.4068799-1-christian.brauner@ubuntu.com>
Date:   Wed, 17 Jun 2020 00:56:11 +0200
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     LKML <linux-kernel@...r.kernel.org>
Cc:     Jan Stancek <jstancek@...hat.com>, Cyril Hrubis <chrubis@...e.cz>,
        kernel test robot <rong.a.chen@...el.com>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Jann Horn <jannh@...gle.com>, lkp@...ts.01.org,
        Aleksa Sarai <cyphar@...har.com>,
        Michael Kerrisk <mtk.manpages@...il.com>, ltp@...ts.linux.it,
        Serge Hallyn <serge@...lyn.com>,
        Christian Brauner <christian.brauner@...ntu.com>
Subject: [PATCH 1/2] nsproxy: restore EINVAL for non-namespace file descriptor

The LTP testsuite reported a regression where users would now see EBADF
returned instead of EINVAL when an fd was passed that referred to an open
file but the file was not a nsfd. Fix this by continuing to report EINVAL.

Reported-by: kernel test robot <rong.a.chen@...el.com>
Cc: Jan Stancek <jstancek@...hat.com>
Cc: Cyril Hrubis <chrubis@...e.cz>
Link: https://lore.kernel.org/lkml/20200615085836.GR12456@shao2-debian
Fixes: 303cc571d107 ("nsproxy: attach to namespaces via pidfds")
Signed-off-by: Christian Brauner <christian.brauner@...ntu.com>
---
I plan on sending this to Linus once it has sat in for-next for a few
days.
---
 kernel/nsproxy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/nsproxy.c b/kernel/nsproxy.c
index b03df67621d0..cd356630a311 100644
--- a/kernel/nsproxy.c
+++ b/kernel/nsproxy.c
@@ -531,7 +531,7 @@ SYSCALL_DEFINE2(setns, int, fd, int, flags)
 	} else if (!IS_ERR(pidfd_pid(file))) {
 		err = check_setns_flags(flags);
 	} else {
-		err = -EBADF;
+		err = -EINVAL;
 	}
 	if (err)
 		goto out;

base-commit: b3a9e3b9622ae10064826dccb4f7a52bd88c7407
-- 
2.27.0