linux-kernel - Re: [PATCH 1/2] e1000e: Do not wake up the system via WOL if device wakeup is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 16 Jun 2020 15:01:01 +0800
From:   Chen Yu <yu.c.chen@...el.com>
To:     "Brown, Aaron F" <aaron.f.brown@...el.com>
Cc:     "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "Kok, Auke-jan H" <auke-jan.h.kok@...el.com>,
        Jeff Garzik <jeff@...zik.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Brown, Len" <len.brown@...el.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        "Shevchenko, Andriy" <andriy.shevchenko@...el.com>,
        "Neftin, Sasha" <sasha.neftin@...el.com>,
        "Lifshits, Vitaly" <vitaly.lifshits@...el.com>,
        "Stable@...r.kernel.org" <Stable@...r.kernel.org>
Subject: Re: [PATCH 1/2] e1000e: Do not wake up the system via WOL if device
 wakeup is disabled

On Tue, Jun 16, 2020 at 02:51:27AM +0800, Brown, Aaron F wrote:
> > From: Chen Yu <yu.c.chen@...el.com>
> > Sent: Thursday, May 21, 2020 10:59 AM
> > To: Kirsher, Jeffrey T <jeffrey.t.kirsher@...el.com>; David S. Miller
> > <davem@...emloft.net>; Jakub Kicinski <kuba@...nel.org>; Kok, Auke-jan H
> > <auke-jan.h.kok@...el.com>; Jeff Garzik <jeff@...zik.org>
> > Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; linux-
> > kernel@...r.kernel.org; Brown, Len <len.brown@...el.com>; Rafael J. Wysocki
> > <rjw@...ysocki.net>; Shevchenko, Andriy <andriy.shevchenko@...el.com>;
> > Neftin, Sasha <sasha.neftin@...el.com>; Lifshits, Vitaly
> > <vitaly.lifshits@...el.com>; Chen, Yu C <yu.c.chen@...el.com>;
> > Stable@...r.kernel.org
> > Subject: [PATCH 1/2] e1000e: Do not wake up the system via WOL if device
> > wakeup is disabled
> >
> > Currently the system will be woken up via WOL(Wake On Lan) even if the
> > device wakeup ability has been disabled via sysfs:
> >  cat /sys/devices/pci0000:00/0000:00:1f.6/power/wakeup
> >  disabled
> >
> > The system should not be woken up if the user has explicitly
> > disabled the wake up ability for this device.
> >
> > This patch clears the WOL ability of this network device if the
> > user has disabled the wake up ability in sysfs.
> >
> > Fixes: bc7f75fa9788 ("[E1000E]: New pci-express e1000 driver")
> > Reported-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > Cc: <Stable@...r.kernel.org>
> > Signed-off-by: Chen Yu <yu.c.chen@...el.com>
> > ---
> >  drivers/net/ethernet/intel/e1000e/netdev.c | 14 ++++++++++----
> >  1 file changed, 10 insertions(+), 4 deletions(-)
> >
> Tested-by: Aaron Brown <aaron.f.brown@...el.com>
> 
Thanks for testing, Aaron.

Best,
Chenyu