linux-kernel - Re: [PATCH v2] IB/srpt: Remove WARN_ON from srpt_cm_req

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200616062019.GA2141420@unreal>
Date:   Tue, 16 Jun 2020 09:20:19 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Jing Xiangfeng <jingxiangfeng@...wei.com>
Cc:     bvanassche@....org, dledford@...hat.com, jgg@...pe.ca,
        linux-rdma@...r.kernel.org, target-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v2] IB/srpt: Remove WARN_ON from srpt_cm_req_recv

On Tue, Jun 16, 2020 at 09:17:15AM +0800, Jing Xiangfeng wrote:
> It's easy to show that sdev and req are always valid,
> so we remove unnecessary WARN_ON.

So show it in the commit message, please.

>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@...wei.com>
> ---
>  drivers/infiniband/ulp/srpt/ib_srpt.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
> index ef7fcd3..0fa65c6 100644
> --- a/drivers/infiniband/ulp/srpt/ib_srpt.c
> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
> @@ -2156,9 +2156,6 @@ static int srpt_cm_req_recv(struct srpt_device *const sdev,
>
>  	WARN_ON_ONCE(irqs_disabled());
>
> -	if (WARN_ON(!sdev || !req))
> -		return -EINVAL;
> -
>  	it_iu_len = be32_to_cpu(req->req_it_iu_len);
>
>  	pr_info("Received SRP_LOGIN_REQ with i_port_id %pI6, t_port_id %pI6 and it_iu_len %d on port %d (guid=%pI6); pkey %#04x\n",
> --
> 1.8.3.1
>
>