linux-kernel - Re: [PATCH] HID: i2c-hid: add Trekstor Surfbook E11B to descriptor override

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <197d680d-a38b-b478-1b7a-9c821ada0846@redhat.com>
Date:   Tue, 16 Jun 2020 13:30:14 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Federico Ricchiuto <fed.ricchiuto@...il.com>, jikos@...nal.org
Cc:     Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: i2c-hid: add Trekstor Surfbook E11B to descriptor
 override

Hi,

On 6/15/20 10:49 PM, Federico Ricchiuto wrote:
> The Mediacom FlexBook edge13 uses the SIPODEV SP1064 touchpad, which does
> not supply descriptors, so it has to be added to the override list.
> 
> Signed-off-by: Federico Ricchiuto <fed.ricchiuto@...il.com>

It looks like you copied and pasted part of the commit message from
another patch (which is fine), but you need to update the Subject
(the first line of the commit message) the Subject now still
mentions the Trekstor Surfbook E11B rather then the
Mediacom FlexBook edge13.

Otherwise this looks good to me.

Regards,

Hans


> ---
>   drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c b/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c
> index a66f08041a1a..bb3f802935cc 100644
> --- a/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c
> +++ b/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c
> @@ -373,6 +373,14 @@ static const struct dmi_system_id i2c_hid_dmi_desc_override_table[] = {
>   		},
>   		.driver_data = (void *)&sipodev_desc
>   	},
> +	{
> +		.ident = "Mediacom FlexBook edge 13",
> +		.matches = {
> +			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "MEDIACOM"),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "FlexBook_edge13-M-FBE13"),
> +		},
> +		.driver_data = (void *)&sipodev_desc
> +	},
>   	{
>   		.ident = "Odys Winbook 13",
>   		.matches = {
>