linux-kernel - Re: [PATCH v2 19/24] dyndbg: accept query terms like module:foo and file=bar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200616115727.GN31238@alley>
Date:   Tue, 16 Jun 2020 13:57:27 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     Jim Cromie <jim.cromie@...il.com>
Cc:     jbaron@...mai.com, linux-kernel@...r.kernel.org,
        akpm@...uxfoundation.org, gregkh@...uxfoundation.org,
        linux@...musvillemoes.dk
Subject: Re: [PATCH v2 19/24] dyndbg: accept query terms like module:foo and
 file=bar

On Sat 2020-06-13 09:57:33, Jim Cromie wrote:
> Current code expects "keyword" "arg" as 2 space separated words.
> Change to also accept "keyword:arg" and "keyword=arg" forms as well,
> and drop !(nwords%2) requirement.
> 
> Then in rest of function, use new keyword,arg variables instead of
> word[i],word[i+1]

I like the idea. But please allow only one form. IMHO, parameter=value
is a common way to pass values to commandline parameters.

Note that "keyword" and "arg" is strange naming, especially "arg".

Best Regards,
Petr