linux-kernel - Re: [PATCH] compiler_attributes.h: Support no_sanitize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72kH3mw3yRpyjrCNxKMXtRmx8a_Yto_bOct2O0OZ_UMyuA@mail.gmail.com>
Date:   Tue, 16 Jun 2020 15:09:33 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Marco Elver <elver@...gle.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        kernel test robot <lkp@...el.com>, kbuild-all@...ts.01.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] compiler_attributes.h: Support no_sanitize_undefined
 check with GCC 4

Hi Marco,

On Tue, Jun 16, 2020 at 1:15 AM Marco Elver <elver@...gle.com> wrote:
>
> UBSAN is supported since GCC 4.9, which unfortunately did not yet have
> __has_attribute(). To work around, the __GCC4_has_attribute workaround
> requires defining which compiler version supports the given attribute.
>
> In the case of no_sanitize_undefined, it is the first version that
> supports UBSAN, which is GCC 4.9.
>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Marco Elver <elver@...gle.com>
> ---

I am happy to see the `__GCC4_has_attribute` workaround is useful
outside the file, too (originally the list was meant to be used inside
the file itself, but I see it is good to reuse it).

Reviewed-by: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>

Cheers,
Miguel