linux-kernel - Re: [Query]usb: dwc2: suspend/resume support for DWC2_POWER_DOWN_PARAM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <65502475-28b0-6a27-4494-d642192a599a@synopsys.com>
Date:   Tue, 16 Jun 2020 13:53:37 +0000
From:   Minas Harutyunyan <Minas.Harutyunyan@...opsys.com>
To:     Jisheng Zhang <Jisheng.Zhang@...aptics.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [Query]usb: dwc2: suspend/resume support for
 DWC2_POWER_DOWN_PARAM_NONE case

Hi Jisheng,

On 6/16/2020 1:03 PM, Jisheng Zhang wrote:
> Hi,
> 
> After reading current dwc2 code, I got an impression that resume from suspend
> to ram isn't supported for DWC2_POWER_DOWN_PARAM_NONE case, right? In fact
'ram' Do you mean on suspend save registers in RAM?
If yes, then in case when power_down is _NONE then no any register 
saving/restoring to/from RAM should be performing.
> we do see usb device can't resume properly with DWC2_POWER_DOWN_PARAM_NONE case.
> 
If you see any issue on resume in mentioned case then more probably is 
some another issue which can debugged.

> If the impression is true, what's the proper technical direction? Add
> dwc2_host_enter_suspend() as dwc2_host_enter_hibernation()
> and
> dwc2_host_exit_suspend() as dwc2_host_exit_hibernation()?
> 
> Thanks in advance,
> Jisheng
> 
Thanks,
Minas