lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 17 Jun 2020 13:24:49 -0700 From: Stephen Boyd <swboyd@...omium.org> To: Douglas Anderson <dianders@...omium.org>, Mark Brown <broonie@...nel.org> Cc: Alok Chauhan <alokc@...eaurora.org>, skakit@...eaurora.org, Douglas Anderson <dianders@...omium.org>, Andy Gross <agross@...nel.org>, Bjorn Andersson <bjorn.andersson@...aro.org>, linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org Subject: Re: [PATCH v3 1/5] spi: spi-geni-qcom: No need for irqsave variant of spinlock calls Quoting Douglas Anderson (2020-06-16 03:40:46) > The driver locks its locks in two places. > > In the first usage of the lock the function doing the locking already > has a sleeping call and thus we know we can't be called from interrupt > context. That means we can use the "spin_lock_irq" variant of the > function. > > In the second usage of the lock the function is the interrupt handler > and we know interrupt handlers are called with interrupts disabled. > That means we can use the "spin_lock" variant of the function. > > This patch is expected to be a no-op and is just a cleanup / slight > optimization. > > Signed-off-by: Douglas Anderson <dianders@...omium.org> > --- Reviewed-by: Stephen Boyd <swboyd@...omium.org>
Powered by blists - more mailing lists